szehon-ho commented on code in PR #10203:
URL: https://github.com/apache/iceberg/pull/10203#discussion_r1640779604
##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -94,6 +105,188 @@ static CloseableIterable<FileScanTask> planFiles(
table, manifest, projectedSchema, schemaString, specString,
residuals));
}
+ /**
+ * Evaluates an {@link Expression} on a {@link ManifestFile} to test whether
a given data or
+ * delete manifests shall be included in the scan
+ */
+ private static class ManifestContentEvaluator {
+
+ private static final Set<Integer> DELETE_CONTENT_SET =
+ ImmutableSet.of(FileContent.EQUALITY_DELETES.id(),
FileContent.POSITION_DELETES.id());
Review Comment:
Maybe if we change the method, we may not need this at all, so we can try to
address the next comments first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
