danielcweeks commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1640748623
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2106,6 +2210,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+ PlanTask:
+ description:
+ An opaque JSON object that contains information provided by the REST
server
+ to be utilized by clients for distributed table scan planning; should
be supplied
+ as is for input in `PlanTable` operation.
+ type: object
+
+ FileScanTask:
+ type: object
+ required:
+ - data-file
+ properties:
+ data-file:
+ $ref: '#/components/schemas/DataFile'
+ delete-files:
+ oneOf:
Review Comment:
It seems like we might be able define this as:
```yaml
delete-files:
type: array
items:
anyOf:
- $ref: '#/components/schemas/PositionDeleteFile'
- $ref: '#/components/schemas/EqualityDeleteFile'
```
I think each have a type enum that can be used to determine the underlying
file type. That way there's just one list of delete files.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2106,6 +2210,32 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+ PlanTask:
+ description:
+ An opaque JSON object that contains information provided by the REST
server
+ to be utilized by clients for distributed table scan planning; should
be supplied
+ as is for input in `PlanTable` operation.
+ type: object
+
+ FileScanTask:
+ type: object
+ required:
+ - data-file
+ properties:
+ data-file:
+ $ref: '#/components/schemas/DataFile'
+ delete-files:
+ oneOf:
Review Comment:
It seems like we might be able to define this as:
```yaml
delete-files:
type: array
items:
anyOf:
- $ref: '#/components/schemas/PositionDeleteFile'
- $ref: '#/components/schemas/EqualityDeleteFile'
```
I think each have a type enum that can be used to determine the underlying
file type. That way there's just one list of delete files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
