liurenjie1024 commented on code in PR #400:
URL: https://github.com/apache/iceberg-rust/pull/400#discussion_r1637923809
##########
crates/iceberg/Cargo.toml:
##########
@@ -28,6 +28,10 @@ repository = { workspace = true }
license = { workspace = true }
keywords = ["iceberg"]
+[features]
+storage-fs = ["opendal/services-fs"]
Review Comment:
So by default we don't include any storage backend? This seems inconvenient
to me. How about this:
1. We add a default feature to include most common storage backend such as
fs and s3.
2. Also add a `storage-all` feature to include all storage features.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
