findepi commented on PR #10485: URL: https://github.com/apache/iceberg/pull/10485#issuecomment-2161479241
thank you @jbonofre for your review and feedback! > Not sure it makes sense to trigger revapi (api compatibility workflow) when gradle or github folders are updated. > > Can you please provide the rationale here ? what if i change the revapi (api compatibility workflow) itself? without any change, the build won't trigger, so we won't know if the changed workflow works what if i change something in the build system (e.g. gradle version) that breaks revapi? without any change, the build won't trigger, so we won't know if the build system change impacted the revapi workflow. (of course, this change doesn't safeguard against silent problems like described here https://github.com/apache/iceberg/issues/10368#issuecomment-2161039351) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
