rodmeneses commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1634032064


##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java:
##########
@@ -140,8 +141,7 @@ public void testCheckAndGetEqualityFieldIds() {
 
     DataStream<Row> dataStream =
         env.addSource(new BoundedTestSource<>(ImmutableList.of()), 
ROW_TYPE_INFO);
-    FlinkSink.Builder builder =
-        FlinkSink.forRow(dataStream, SimpleDataUtil.FLINK_SCHEMA).table(table);
+    Builder builder = IcebergSink.forRow(dataStream, 
SimpleDataUtil.FLINK_SCHEMA).table(table);

Review Comment:
   thanks for pointing this out. I did create separate tests to assert the new 
functionality. In this case, though, the naming of the unit test file got in 
the middle, and I didn't realize that I was switching existing tests.
   In the current codebase we have unit tests with these names:
   
   1. TestFlinkIcebergSinkV2
   2. TestFlinkIcebergSink
   3. TestFlinkIcebergSinkV2Base
   4. TestFlinkIcebergSinkBase
   
   I will introduce new ones called
   1. TestIcebergSink
   2. TestIcebergSinkBase
   
   and the original 4 will keep the same
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to