RussellSpitzer commented on code in PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#discussion_r1633849167
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -355,6 +355,17 @@ public static Schema reassignOrRefreshIds(
return new Schema(struct.fields(), refreshIdentifierFields(struct,
schema));
}
+ /**
+ * Assigns fresh ids from the {@link GetID getId function} for all fields in
a type.
+ *
+ * @param type a type
+ * @param getId an id assignment function
+ * @return an structurally identical type with new ids assigned by the
nextId function
Review Comment:
Name here is incorrect, nextId is not defined, getId is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
