jgprogramming commented on PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#issuecomment-2155503910

   So I've reviewed this PR, built it, tested it in our qa table that has close 
to 30k columns and it is working perfectly :) would really be interested in 
seeing this merged so I don't have to maintain custom version of iceberg lib.
   
   One small note, would it be possible to remove old schema definitions from 
metadata file? With frequent schema evolution and a large amount of columns the 
metadata file grows very quickly, I'm wondering if during rewrite_manifest it 
would make sense to iterate over used schemas and keep only those? Maybe in 
another PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to