nastra commented on code in PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#discussion_r1629728440
##########
api/src/main/java/org/apache/iceberg/util/DateTimeUtil.java:
##########
@@ -185,7 +194,28 @@ private static int convertMicros(long micros, ChronoUnit
granularity) {
}
}
+ public static long convertNanos(long nanos, ChronoUnit granularity) {
+ if (nanos >= 0) {
+ long epochSecond = Math.floorDiv(nanos, NANOS_PER_SECOND);
+ long nanoAdjustment = Math.floorMod(nanos, NANOS_PER_SECOND);
+ return granularity.between(EPOCH, toOffsetDateTime(epochSecond,
nanoAdjustment));
+ } else {
+ // add 1 nano to the value to account for the case where there is
exactly 1 unit between
+ // the timestamp and epoch because the result will always be decremented.
+ long epochSecond = Math.floorDiv(nanos, NANOS_PER_SECOND);
Review Comment:
the `else` path doesn't seem to be tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
