HonahX commented on code in PR #363: URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1625453929
########## pyiceberg/table/__init__.py: ########## @@ -2751,10 +2824,12 @@ def _parquet_files_to_data_files(table_metadata: TableMetadata, file_paths: List class _MergingSnapshotProducer(UpdateTableMetadata["_MergingSnapshotProducer"]): Review Comment: I feel that `_SnapshotProducer` may be more accurate here since it does not merge manifests. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
