Fokko opened a new pull request, #10424:
URL: https://github.com/apache/iceberg/pull/10424

   It is _very_ easy to accidentally write to the `main` branch through the 
GitHub UI:
   
   
![image](https://github.com/apache/iceberg/assets/1134248/f0db2d2c-c28e-4e09-bb6c-61e93049f976)
   
   This happened to me just now 😭  
https://github.com/apache/iceberg/commit/23eb5941cd599183be63676c9d1379ba102b1a97
 While through the GitHub UI, the changes will probably be minor, I think it is 
good to avoid accidents and require explicit approval. After setting this, 
you'll get:
   
   
![image](https://github.com/apache/iceberg/assets/1134248/d170f07e-a669-44e8-a1e7-7171dad2eb33)
   
   In practice, we also wait for all the checks to be green, but might be good 
to enforce that as well. WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to