liurenjie1024 commented on code in PR #388:
URL: https://github.com/apache/iceberg-rust/pull/388#discussion_r1623135632
##########
crates/iceberg/src/spec/schema.rs:
##########
@@ -327,6 +327,12 @@ impl Schema {
&self.r#struct
}
+ /// Returns [`identifier_field_ids`].
+ #[inline]
+ pub fn identifier_field_ids(&self) -> &HashSet<i32> {
Review Comment:
```suggestion
pub fn identifier_field_ids(&self) -> impl Iterator<item = i32> {
```
How about this? I'm hesitating to expose internal data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
