jeesou commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1622261695
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.actions; + +import java.io.IOException; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.StatisticsFile; +import org.apache.iceberg.Table; +import org.apache.iceberg.actions.AnalyzeTable; +import org.apache.iceberg.actions.ImmutableAnalyzeTable; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.puffin.StandardBlobTypes; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.spark.JobGroupInfo; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; +import org.apache.spark.sql.SparkSession; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** Computes the statistic of the given columns and stores it as Puffin files. */ Review Comment: Hi @karuppayya , as the above discussions suggest, there can be multiple engines like spark, presto, trino etc, who might want to query of the same data right. So in such a scenario the sketches that are generated by Spark or suppose Presto, must be readable by the alternate engine right. This question is coming because I ran one Analyze query on Presto and the puffin file it created looks like this -> {"blobs":[{"type":"apache-datasketches-theta-v1","fields":[2],"snapshot-id":7724902347602477706, "sequence-number":1,"offset":44,"length":40,"properties":{"ndv":"3"}}],"properties":{"created-by":"presto-testversion"}} where as the one created by iceberg through the changes of this PR looks like this -> {"blobs":[{"type":"apache-datasketches-theta-v1","fields":[3], "snapshot-id":5334747061548805461,"sequence-number":1,"offset":4,"length":32}],"properties" If seen properly the "{"ndv":"3"}" portion is missing in the iceberg change. So can we make any modifications or any suggestions from your side may be? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
