stevenzwu commented on code in PR #10393:
URL: https://github.com/apache/iceberg/pull/10393#discussion_r1619230274
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailoverWithWatermarkExtractor.java:
##########
@@ -48,10 +52,17 @@ public class
TestIcebergSourceFailoverWithWatermarkExtractor extends TestIceberg
@Override
protected IcebergSource.Builder<RowData> sourceBuilder() {
- return IcebergSource.<RowData>builder()
+ Configuration config = new Configuration();
+
config.setInteger(FlinkConfigOptions.SOURCE_READER_FETCH_BATCH_RECORD_COUNT,
128);
Review Comment:
I see. this config is probably not required for `TestIcebergSourceFailover`,
because only small number of records are generated per data file. This config
is probably copied over unnecessarily from some specific tests like
`TestArrayPoolDataIteratorBatcherRowData`.
either way is fine with me (copying it here or not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
