Fokko commented on code in PR #700:
URL: https://github.com/apache/iceberg-python/pull/700#discussion_r1618699755
##########
tests/integration/test_rest_schema.py:
##########
@@ -1730,19 +1730,17 @@ def test_move_nested_field_after_first(catalog:
Catalog) -> None:
with tbl.update_schema() as schema_update:
schema_update.move_before("struct.data", "struct.count")
Review Comment:
I don't think we want to do that. The `String` and `LargeString` are an
Arrow encoding detail (similar to the categorial type). Maybe we should have a
different version of `to_requested_schema` where we don't cast, and just keep
the original types? If the types are incompatible (for example, the field-id
points to a string in the schema, and you try to write a boolean, it should
fail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
