Fokko commented on code in PR #683:
URL: https://github.com/apache/iceberg-python/pull/683#discussion_r1618684588
##########
tests/integration/test_writes/test_writes.py:
##########
@@ -609,17 +610,18 @@ def test_write_and_evolve(session_catalog: Catalog,
format_version: int) -> None
@pytest.mark.integration
-@pytest.mark.parametrize("format_version", [2])
-def test_create_table_transaction(session_catalog: Catalog, format_version:
int) -> None:
- if format_version == 1:
+@pytest.mark.parametrize("format_version", [1, 2])
+@pytest.mark.parametrize('catalog',
[pytest.lazy_fixture('session_catalog_hive'),
pytest.lazy_fixture('session_catalog')])
Review Comment:
We're mixing double and single quotes 😱 Shouldn't Ruff fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
