Fokko commented on code in PR #10386: URL: https://github.com/apache/iceberg/pull/10386#discussion_r1616786126
########## dev/revapi: ########## @@ -0,0 +1,86 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +export REVAPI_VERSION=0.12.0 +export OLD_VERSION=1.5.2 + +# Go to the root directory +ROOT_DIR="$(cd "`dirname "$0"`"/..; pwd)" +cd "$ROOT_DIR" + +REVAPI_WORKING_DIR="$ROOT_DIR/lib/temp/revapi" + +mkdir -p $REVAPI_WORKING_DIR + +export REVAPI_ZIP="$ROOT_DIR"/lib/revapi-standalone-${REVAPI_VERSION}-standalone.zip + +if test -x "$JAVA_HOME/bin/java"; then + declare java_cmd="$JAVA_HOME/bin/java" +else + declare java_cmd=java +fi + +REVAPI_URL=https://repo1.maven.org/maven2/org/revapi/revapi-standalone/${REVAPI_VERSION}/revapi-standalone-${REVAPI_VERSION}-standalone.zip + +if [ ! -f "$REVAPI_ZIP" ]; then + printf "Downloading revapi\n" + REVAPI_ZIP_DL="${REVAPI_ZIP}.part" + if [ $(command -v curl) ]; then + curl -L --silent "${REVAPI_URL}" > "$REVAPI_ZIP_DL" && mv "$REVAPI_ZIP_DL" "$REVAPI_ZIP" + elif [ $(command -v wget) ]; then + wget --quiet ${REVAPI_URL} -O "$REVAPI_ZIP_DL" && mv "$REVAPI_ZIP_DL" "$REVAPI_ZIP" + else + printf "You do not have curl or wget installed, please install revapi manually.\n" + exit 1 + fi +fi + +unzip -q -o "$REVAPI_ZIP" -d "$ROOT_DIR/lib" + +export REVAPI_HOME="$ROOT_DIR/lib/revapi-$REVAPI_VERSION" + +REVAPI_PROJECTS="api core parquet orc common data" + +REVAPI_OUT=lib/revapi.out +rm "$REVAPI_OUT" +for REVAPI_PROJECT in $REVAPI_PROJECTS; do + echo "========================" + echo "Checking iceberg-$REVAPI_PROJECT" + echo "Downloading iceberg-$REVAPI_PROJECT $OLD_VERSION" + if [ $(command -v curl) ]; then + curl -L --silent "https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-$REVAPI_PROJECT/$OLD_VERSION/iceberg-$REVAPI_PROJECT-$OLD_VERSION.jar"; > "$REVAPI_WORKING_DIR/iceberg-$REVAPI_PROJECT-$OLD_VERSION.jar" + elif [ $(command -v wget) ]; then + wget --quiet "https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-$REVAPI_PROJECT/$OLD_VERSION/iceberg-$REVAPI_PROJECT-$OLD_VERSION.jar"; -O "$REVAPI_REVAPI_WORKING_DIR/iceberg-$REVAPI_PROJECT-$OLD_VERSION.jar" + else + printf "You do not have curl or wget installed, please download artifact manually.\n" + exit 1 + fi + $REVAPI_HOME/revapi.sh --extensions=org.revapi:revapi-java:0.28.1,org.revapi:revapi-reporter-text:0.15.0 --old "$REVAPI_WORKING_DIR/iceberg-$REVAPI_PROJECT-$OLD_VERSION.jar" --new $REVAPI_PROJECT/build/libs/iceberg-$REVAPI_PROJECT*SNAPSHOT.jar -Drevapi.java.missing-classes.behavior=ignore -Drevapi.reporter.text.minCriticality=error -Drevapi.reporter.text.append=true -Drevapi.reporter.text.output=$REVAPI_OUT -Drevapi.reporter.text.minSeverity=BREAKING + if [[ $(grep "SOURCE: BREAKING" $REVAPI_OUT) ]]; then + echo "==================================================================================" + echo "API/ABI breaks detected." + echo "Adding RevAPI breaks should only be done after going through a deprecation cycle." Review Comment: ```suggestion echo "API/ABI breaks detected." echo "Details can be found in ${REVAPI_OUT}" echo "Adding RevAPI breaks should only be done after going through a deprecation cycle." ``` ########## dev/revapi: ########## @@ -0,0 +1,86 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +export REVAPI_VERSION=0.12.0 +export OLD_VERSION=1.5.2 + +# Go to the root directory +ROOT_DIR="$(cd "`dirname "$0"`"/..; pwd)" +cd "$ROOT_DIR" + +REVAPI_WORKING_DIR="$ROOT_DIR/lib/temp/revapi" + +mkdir -p $REVAPI_WORKING_DIR + +export REVAPI_ZIP="$ROOT_DIR"/lib/revapi-standalone-${REVAPI_VERSION}-standalone.zip + +if test -x "$JAVA_HOME/bin/java"; then + declare java_cmd="$JAVA_HOME/bin/java" +else + declare java_cmd=java +fi + +REVAPI_URL=https://repo1.maven.org/maven2/org/revapi/revapi-standalone/${REVAPI_VERSION}/revapi-standalone-${REVAPI_VERSION}-standalone.zip + +if [ ! -f "$REVAPI_ZIP" ]; then + printf "Downloading revapi\n" + REVAPI_ZIP_DL="${REVAPI_ZIP}.part" + if [ $(command -v curl) ]; then + curl -L --silent "${REVAPI_URL}" > "$REVAPI_ZIP_DL" && mv "$REVAPI_ZIP_DL" "$REVAPI_ZIP" + elif [ $(command -v wget) ]; then + wget --quiet ${REVAPI_URL} -O "$REVAPI_ZIP_DL" && mv "$REVAPI_ZIP_DL" "$REVAPI_ZIP" + else + printf "You do not have curl or wget installed, please install revapi manually.\n" + exit 1 + fi +fi + +unzip -q -o "$REVAPI_ZIP" -d "$ROOT_DIR/lib" + +export REVAPI_HOME="$ROOT_DIR/lib/revapi-$REVAPI_VERSION" + +REVAPI_PROJECTS="api core parquet orc common data" + +REVAPI_OUT=lib/revapi.out +rm "$REVAPI_OUT" Review Comment: ```suggestion rm -f "$REVAPI_OUT" ``` ########## build.gradle: ########## @@ -139,35 +137,6 @@ subprojects { apply plugin: 'java-library' - if (project.name in REVAPI_PROJECTS) { - apply plugin: 'com.palantir.revapi' - revapi { - oldGroup = project.group - oldName = project.name - oldVersion = "1.5.0" - } - - tasks.register('showDeprecationRulesOnRevApiFailure') { - doLast { - throw new RuntimeException("==================================================================================" + - "\nAPI/ABI breaks detected.\n" + Review Comment: Can we pre-create this file, possibly with a link to the docs? Otherwise, it might not be obvious -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
