manuzhang commented on code in PR #10252:
URL: https://github.com/apache/iceberg/pull/10252#discussion_r1616533549
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -589,6 +589,21 @@ private Long getStartSnapshotId(Long startTimestamp) {
}
}
+ private Long getEndSnapshotId(Long endTimestamp) {
+ Long endSnapshotId = null;
+ Snapshot oldestSnapshotAfter = SnapshotUtil.oldestAncestorAfter(table,
endTimestamp);
Review Comment:
@flyrain I find`SnapshotUtil.oldestAncestorAfter` can be used here with a
bit of trick. Meanwhile, I think we can move the method to `SnapshotUtil` later
if it's helpful elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
