Fokko commented on code in PR #569:
URL: https://github.com/apache/iceberg-python/pull/569#discussion_r1615924919
##########
pyiceberg/table/__init__.py:
##########
@@ -2931,14 +3161,52 @@ def _deleted_entries(self) -> List[ManifestEntry]:
return []
-class OverwriteFiles(_MergingSnapshotProducer):
+class OverwriteFiles(_MergingSnapshotProducer["OverwriteFiles"]):
Review Comment:
This is a very valid point. I was playing around with Java as well, and
identified this as a bug https://github.com/apache/iceberg/issues/10122 I think
having a separate class makes it easier to know what happening (it creates an
`OVERWRITE` snapshot), but I agree, it is part of the delete operation, so it
could also be merged into `DeleteFiles`.
Splitting it might keep things clearer and avoid bugs like these:
https://github.com/apache/iceberg/pull/10123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
