rtadepalli commented on code in PR #68:
URL: https://github.com/apache/iceberg-go/pull/68#discussion_r1609138974


##########
cmd/iceberg/main.go:
##########
@@ -34,16 +34,21 @@ import (
 const usage = `iceberg.
 
 Usage:
-  iceberg list [options] [PARENT]
-  iceberg describe [options] [namespace | table] IDENTIFIER
-  iceberg (schema | spec | uuid | location) [options] TABLE_ID
-  iceberg drop [options] (namespace | table) IDENTIFIER
-  iceberg files [options] TABLE_ID [--history]
-  iceberg rename [options] <from> <to>
-  iceberg properties [options] get (namespace | table) IDENTIFIER [PROPNAME]
-  iceberg properties [options] set (namespace | table) IDENTIFIER PROPNAME 
VALUE
-  iceberg properties [options] remove (namespace | table) IDENTIFIER PROPNAME
-  iceberg -h | --help | --version
+  iceberg [command] [options] [arguments]

Review Comment:
   @zeroshade Apologies, this slipped through my radar. I don't think that this 
is breaking the CLI:
   ```
   ~/Software/iceberg-go/cmd/iceberg (improve-cli-help-text*) ยป ./iceberg 
--help                                                                          
                                                   ramasai@Ramasais-MacBook-Air
   iceberg.
   
   Usage:
     iceberg [command] [options] [arguments]
     iceberg -h | --help
     iceberg --version
   
   Commands:
     describe    Describe a namespace or a table.
     list        List tables or namespaces.
     schema      Get the schema of the table.
     spec        Return the partition spec of the table.
     uuid        Return the UUID of the table.
     location    Return the location of the table.
     drop        Operations to drop a namespace or table.
     files       List all the files of the table.
     rename      Rename a table.
     properties  Properties on tables/namespaces.
   
   Arguments:
     PARENT         Catalog parent namespace
     IDENTIFIER     fully qualified namespace or table
     TABLE_ID       full path to a table
     PROPNAME       name of a property
     VALUE          value to set
   
   Options:
     --catalog TEXT     specify the catalog type [default: rest]
     --uri TEXT         specify the catalog URI
     --output TYPE      output type (json/text) [default: text]
     --credential TEXT  specify credentials for the catalog
     --warehouse TEXT   specify the warehouse to use
   
   Example Usages
     iceberg list [options] [PARENT]
     iceberg describe [options] [namespace | table] IDENTIFIER
     iceberg (schema | spec | uuid | location) [options] TABLE_ID
     iceberg drop [options] (namespace | table) IDENTIFIER
     iceberg files [options] TABLE_ID [--history]
     iceberg rename [options] <from> <to>
     iceberg properties [options] get (namespace | table) IDENTIFIER [PROPNAME]
     iceberg properties [options] set (namespace | table) IDENTIFIER PROPNAME 
VALUE
     iceberg properties [options] remove (namespace | table) IDENTIFIER PROPNAME
   ```
   
   I tested this before putting up the PR -- unless I am misunderstanding what 
you mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to