jackye1995 commented on PR #10359: URL: https://github.com/apache/iceberg/pull/10359#issuecomment-2122678361
Thanks for the quick feedback Dan! I think this is a similar discussion to the MV one for properties vs new metadata, I think at least in this case the property-based approach fits the REST model better. In this approach, we define this context field, then define properties that should be passed in this field in the spec. This means that the spec can keep evolving without changing the client implementation. This avoids the need to keep updating the Iceberg client to accept new contexts. Otherwise we stuck with the same model as the current one, that we need to chase down all the users to update all the clients. This approach is also already used in the `config` field in `LoadTableResponse`, takes a map but should pass in only catalog properties. I could also argue that it is working around the spec, because why didn't we create dedicated fields for vending credentials? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
