amogh-jahagirdar commented on code in PR #10352:
URL: https://github.com/apache/iceberg/pull/10352#discussion_r1605884398
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -533,6 +537,34 @@ private static Schema applyChanges(
}
}
+ Map<Integer, List<Integer>> specToDeletes = Maps.newHashMap();
+ if (base != null) {
+ for (int fieldIdToDelete : deletes) {
+ for (PartitionSpec spec : base.specs()) {
+ if (spec.schema().findField(fieldIdToDelete) != null) {
Review Comment:
This should be spec field, not schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]