syun64 commented on issue #737: URL: https://github.com/apache/iceberg-python/issues/737#issuecomment-2113105812
> * How does rollback_to_timestamp use `set_ref_snapshot()`? In the [rollback_to_timestamp documentation](https://iceberg.apache.org/docs/1.5.1/spark-procedures/#rollback_to_timestamp), inputs are Table and timestamp, and I can't find a `snapshot_by_timestamp()` api to get the snapshot_id. - Yeah I think it would be helpful to introduce a `snapshot_by_timestamp` utility function to get the snapshot - just like you mentioned, that would help recover feature parity with the existing Java API > * for cherrypick_snapshot and publish_changes ([docs](https://iceberg.apache.org/docs/1.5.1/spark-procedures/#cherrypick_snapshot)), wouldn't we need an `add_snapshot()` table api ? I noticed both `add_snapshot()` and `set_ref_snapshot()` were removed in the [same PR](https://github.com/apache/iceberg-python/pull/471/files#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef326db3d3d03cee9bL328). Do we bring back `add_snapshot()` as well? I don't think `add_snapshot` needs to be an API because the function is incredibly simple, in that it just adds a AddSnapshotUpdate table update and AssertTableUUID requirement. I think instead, functions like cherrypick_snapshot, publish_changes should be separate APIs that builds the new snapshot and then makes a commit with the updated snapshot. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
