nastra commented on code in PR #10334:
URL: https://github.com/apache/iceberg/pull/10334#discussion_r1600093526
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java:
##########
@@ -647,19 +648,33 @@ public void testRemoveOrphanFilesProcedureWithPrefixMode()
"CALL %s.system.remove_orphan_files("
+ "table => '%s',"
+ "equal_schemes => map('file1', 'file'),"
+ + "equal_authorities => map('localhost', '%s'),"
Review Comment:
rather than modifying an existing test I think we should just have a simple
& separate test method that reproduces the underlying issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
