CodingJun commented on issue #10312:
URL: https://github.com/apache/iceberg/issues/10312#issuecomment-2105525236

   I found the code to drop the equality delete files here.
   
   
https://github.com/apache/iceberg/blob/2b21020aedb63c26295005d150c05f0a5a5f0eb2/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L813-L832
   
   - TableMetadata `base` is refreshed, `base.lastSequenceNumber()` is 3.
   - The filtered manifest files minSequenceNumber  is not equal to 
`UNASSIGNED_SEQ`, only the newly append file at t3.
   - So the `minDataSequenceNumber` is also 3, the manifest for equality delete 
will be droped.
   
   I think the `base.lastSequenceNumber()` should be 1 at the start snapshot 
instead of 3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to