amogh-jahagirdar commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1597014821
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -40,6 +40,8 @@ final class JdbcUtil {
// property to control if view support is added to the existing database
static final String SCHEMA_VERSION_PROPERTY = JdbcCatalog.PROPERTY_PREFIX +
"schema-version";
+ static final String RETRYABLE_STATUS_CODES = "retryable_status_codes";
Review Comment:
>But it also means that strict-mode and schema-version should not have been
prefixed by jdbc then.
Right, I think they should not have been.
>We can change that, but as it's user facing, it could be problematic.
> I can work on a PR to deprecated jdbc prefix (not still supporting it) for
strict-mode and schema-version
Sure, we can either deprecate the prefix or just leave as is. Since it's
relatively early days for strict-mode/schema-version in the catalog (e.g. it'll
practically take time for these paths to get exercised, as views get adopted) I
think it makes most sense just to deprecate and correct it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
