osscm commented on issue #10205: URL: https://github.com/apache/iceberg/issues/10205#issuecomment-2099323036
> `iceberg.rest-catalog.warehouse` normally points to a location like `s3://my_bucket/warehouse_location`. Not sure Trino community is OK to use it as the catalog name. Even if that works, do we need any change for REST Spec? I think multipart namespace still work well. Trino can concatenate the catalog_name to the rest table identifier in the client side, e.g. `catalog_name.db1.table1`. Trino right now passes Trino's catalog name (not the HMS catalog name) like this: https://github.com/trinodb/trino/blob/master/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java#L493 which is added to the session context properties. ``` SessionCatalog.SessionContext(sessionId, session.getUser(), credentials, properties, session.getIdentity()); ``` @flyrain do you know? is it to pass the `trinoCatalog` as header to the RESTCatalog service? extracting header from the session context. https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
