stevenzwu commented on code in PR #10280: URL: https://github.com/apache/iceberg/pull/10280#discussion_r1592780335
########## format/materialized-view-spec.md: ########## @@ -0,0 +1,55 @@ +<!-- + - Licensed to the Apache Software Foundation (ASF) under one or more + - contributor license agreements. See the NOTICE file distributed with + - this work for additional information regarding copyright ownership. + - The ASF licenses this file to You under the Apache License, Version 2.0 + - (the "License"); you may not use this file except in compliance with + - the License. You may obtain a copy of the License at + - + - http://www.apache.org/licenses/LICENSE-2.0 + - + - Unless required by applicable law or agreed to in writing, software + - distributed under the License is distributed on an "AS IS" BASIS, + - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + - See the License for the specific language governing permissions and + - limitations under the License. + --> + +# Iceberg Materialized View Spec + +## Background and Motivation +Iceberg views are a powerful tool to abstract complex queries and share them among different engines. +However, such views are not materialized by default, which means that they are re-computed every time they are queried. Review Comment: nit: remove however. `However, such views` -> `Such logical views` ########## format/materialized-view-spec.md: ########## @@ -0,0 +1,55 @@ +<!-- + - Licensed to the Apache Software Foundation (ASF) under one or more + - contributor license agreements. See the NOTICE file distributed with + - this work for additional information regarding copyright ownership. + - The ASF licenses this file to You under the Apache License, Version 2.0 + - (the "License"); you may not use this file except in compliance with + - the License. You may obtain a copy of the License at + - + - http://www.apache.org/licenses/LICENSE-2.0 + - + - Unless required by applicable law or agreed to in writing, software + - distributed under the License is distributed on an "AS IS" BASIS, + - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + - See the License for the specific language governing permissions and + - limitations under the License. + --> + +# Iceberg Materialized View Spec + +## Background and Motivation +Iceberg views are a powerful tool to abstract complex queries and share them among different engines. +However, such views are not materialized by default, which means that they are re-computed every time they are queried. +This can be inefficient for complex queries that are computed frequently. +Iceberg Materialized views are a way to store the results of an Iceberg view to reuse the computation in subsequent queries. + +## Goals +The goal of this spec is to define the metadata associated with materialized views in Iceberg. +Such metadata allows creating and querying Iceberg materialized views across different engines. + +## Specification +A materialized view is an Iceberg view with a respective Iceberg table that stores the results of the view query. +An Iceberg view is considered a materialized view if it has the `iceberg.materialized.view` property set to `true`. +A materialized view must also reference the storage table identifier in its `iceberg.materialized.view.storage.table` property. + +The specification for the materialized view properties on the view is as follows: Review Comment: regarding property name iceberg.materialized.view, it is redundant to have iceberg there. metadata field name uses hyphen `-`. so maybe like `view-materialized` and `view-storage-table`. ########## format/materialized-view-spec.md: ########## @@ -0,0 +1,55 @@ +<!-- + - Licensed to the Apache Software Foundation (ASF) under one or more + - contributor license agreements. See the NOTICE file distributed with + - this work for additional information regarding copyright ownership. + - The ASF licenses this file to You under the Apache License, Version 2.0 + - (the "License"); you may not use this file except in compliance with + - the License. You may obtain a copy of the License at + - + - http://www.apache.org/licenses/LICENSE-2.0 + - + - Unless required by applicable law or agreed to in writing, software + - distributed under the License is distributed on an "AS IS" BASIS, + - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + - See the License for the specific language governing permissions and + - limitations under the License. + --> + +# Iceberg Materialized View Spec + +## Background and Motivation +Iceberg views are a powerful tool to abstract complex queries and share them among different engines. +However, such views are not materialized by default, which means that they are re-computed every time they are queried. +This can be inefficient for complex queries that are computed frequently. +Iceberg Materialized views are a way to store the results of an Iceberg view to reuse the computation in subsequent queries. Review Comment: minor suggestion `Iceberg materialized view stores the precomputed results of an Iceberg view, which can be reused in subsequent queries to avoid recomputation.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
