zeodtr commented on issue #338: URL: https://github.com/apache/iceberg-rust/issues/338#issuecomment-2097101287
@a-agmon My concerns are as follows: 1. The `manifest_file_schema_fields` hashmap should be calculated only once in an application's lifetime (for performance). 2. There are manifest avro files that have no field-id in the records (for example, avro files written by the current iceberg-rust version.) Java Iceberg library can handle this case. 3. Mapping field values by `field-id` can be slow. 4. In general cases, field mapping should recurse for sub-structs. 5. Reading `file_records` will be pretty slow, since apache_avro's reading function is slow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
