odysa commented on PR #233: URL: https://github.com/apache/iceberg-rust/pull/233#issuecomment-2090540873
Sorry, my bad. I thought I marked this PR ready for review, but I didn't remove the [WIP]. There are some code changes needed to resolve conflicts. Let me know if you have any comments about the idea of the runtime module. It should be good for review. There is a struct `JoinHandle` wrapping handlers from different async runtimes. Implement the `JoinHandleExt` trait for them so they fit in this wrapper. The `poll` from async-std returns `Poll<T>`, but that from tokio returns `Poll<Result<T, JoinError>>`. This is why we need to wrap them in our own `poll`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
