liurenjie1024 commented on code in PR #360:
URL: https://github.com/apache/iceberg-rust/pull/360#discussion_r1587013047


##########
crates/iceberg/src/scan.rs:
##########
@@ -99,7 +107,7 @@ impl<'a> TableScanBuilder<'a> {
     }
 
     /// Build the table scan.
-    pub fn build(self) -> crate::Result<TableScan> {
+    pub fn build(self) -> Result<TableScan> {

Review Comment:
   Sorry for late reply. I argee that we should have a convention, and  I 
prefer to remove the `crate::` prefix. I'm not sure if a linter could enfore 
this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to