kevinjqliu commented on code in PR #678:
URL: https://github.com/apache/iceberg-python/pull/678#discussion_r1585855350
##########
pyiceberg/catalog/__init__.py:
##########
@@ -394,6 +394,11 @@ def table_exists(self, identifier: Union[str, Identifier])
-> bool:
Returns:
bool: True if the table exists, False otherwise.
"""
+ try:
Review Comment:
can we get rid of the other `table_exists` function in the same file?
https://github.com/apache/iceberg-python/blob/87c13b54e44b0c2c5b9cce79072ccdc3d58d6d63/pyiceberg/catalog/__init__.py#L668-L673
##########
pyiceberg/catalog/__init__.py:
##########
@@ -394,6 +394,11 @@ def table_exists(self, identifier: Union[str, Identifier])
-> bool:
Returns:
bool: True if the table exists, False otherwise.
"""
+ try:
Review Comment:
what do you think about changing the REST catalog's `table_exists`
implementation to be similar to this?
https://github.com/apache/iceberg-python/pull/512/files#diff-3bda7391ebd8aa3dcfd6703d8d2764830b9d9c35fa854188a37d69611274bd3dR722-R727
maybe calls `super().table_exists()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
