huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1585769857
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java:
##########
@@ -115,11 +115,11 @@ private String[][] computePreferredLocations() {
public PartitionReaderFactory createReaderFactory() {
if (useParquetBatchReads()) {
int batchSize = readConf.parquetBatchSize();
- return new SparkColumnarReaderFactory(batchSize);
+ return new SparkColumnarReaderFactory(batchSize,
readConf.parquetReaderType());
Review Comment:
Changed. Thanks
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkColumnarReaderFactory.java:
##########
@@ -49,7 +52,9 @@ public PartitionReader<ColumnarBatch>
createColumnarReader(InputPartition inputP
SparkInputPartition partition = (SparkInputPartition) inputPartition;
if (partition.allTasksOfType(FileScanTask.class)) {
- return new BatchDataReader(partition, batchSize);
+ BatchDataReader batchDataReader =
+ new BatchDataReader(partition, batchSize, parquetReaderType);
+ return batchDataReader;
Review Comment:
Fixed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
