amogh-jahagirdar commented on code in PR #10244:
URL: https://github.com/apache/iceberg/pull/10244#discussion_r1582207142
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -171,4 +171,29 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO io)
{
default Integer schemaId() {
return null;
}
+
+ /**
+ * Return a {@link ManifestFile} for each data manifest in this snapshot
which was added in
+ * addedSnapshotId
+ *
+ * @param io a {@link FileIO} instance used for reading files from storage
+ * @return a list of ManifestFile
+ */
+ default List<ManifestFile> dataManifests(FileIO io, Long addedSnapshotId) {
+ throw new UnsupportedOperationException(
+ this.getClass().getName() + " doesn't implement dataManifests(FileIO,
Long)");
Review Comment:
Doesn't need to be unsupported, it can just use the existing data manifests
and filer.
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -171,4 +171,29 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO io)
{
default Integer schemaId() {
return null;
}
+
+ /**
+ * Return a {@link ManifestFile} for each data manifest in this snapshot
which was added in
+ * addedSnapshotId
+ *
+ * @param io a {@link FileIO} instance used for reading files from storage
+ * @return a list of ManifestFile
+ */
+ default List<ManifestFile> dataManifests(FileIO io, Long addedSnapshotId) {
+ throw new UnsupportedOperationException(
+ this.getClass().getName() + " doesn't implement dataManifests(FileIO,
Long)");
Review Comment:
Doesn't need to be unsupported, it can just use the existing data manifests
and filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
