pvary commented on code in PR #10207: URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578865383
########## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamScanSql.java: ########## @@ -48,7 +48,9 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.TestTemplate; +import org.junit.jupiter.api.Timeout; +@Timeout(60) Review Comment: Yeah. My first change (where the validation always happened) caused the test streaming jobs to stuck in restart loop. So the test never finished, and never failed. Took me some time to find the offending test 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
