HonahX opened a new pull request, #653: URL: https://github.com/apache/iceberg-python/pull/653
In https://github.com/apache/iceberg-python/pull/498, the `createTableTransaction` API requires the `_commit_table` to handle both table update and table creation. This PR refactors Glue's `_commit_table` to re-use codes such as requirements validation, metadata update, and new metadata write between the two workflows. This refactoring also solves an extreme case where the table gets dropped after `_commit_table` load the current table and before `_commit_table` update the table. In the previous implementation, the code will accidently slip to the table creation workflow and incorrectly create the table. Try to see if similar implementation pattern can be applied to Hive and Sql in https://github.com/apache/iceberg-python/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
