geruh commented on PR #650: URL: https://github.com/apache/iceberg-python/pull/650#issuecomment-2073414087
I believe in the Java implementation we have a concept of a [PositionOutputStream](https://github.com/apache/iceberg/blob/866021d7d34f274349ce7de1f29d113395e7f28c/api/src/main/java/org/apache/iceberg/io/PositionOutputStream.java#L24) which is used to keep track of bytes written to each file with a position/counter. What we can do here is extend the current `OutputFile`, and `OutputStream` implementations to account for this and roll each based on that position. For instance, the ManifestWriter can use the `AvroFileAppender` which calls it's `length()` method to determine the size. But this length method is calling the `storedLength()` method in `PositionOutputStream`. https://github.com/apache/iceberg/blob/866021d7d34f274349ce7de1f29d113395e7f28c/core/src/main/java/org/apache/iceberg/avro/AvroFileAppender.java#L83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
