nastra commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1576026814
##########
core/src/test/java/org/apache/iceberg/TestFileScanTaskParser.java:
##########
@@ -33,23 +33,64 @@ public void testNullArguments() {
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Invalid file scan task: null");
- Assertions.assertThatThrownBy(() -> FileScanTaskParser.fromJson(null,
true))
+ Assertions.assertThatThrownBy(() -> FileScanTaskParser.fromJson((String)
null, true))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Invalid JSON string for file scan task: null");
+
+ Assertions.assertThatThrownBy(() -> ScanTaskParser.toJson(null))
Review Comment:
this should be in `TestScanTaskParser` as it's using `ScanTaskParser`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
