pvary commented on code in PR #10148: URL: https://github.com/apache/iceberg/pull/10148#discussion_r1572687325
########## mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergWithHiveAutogatherEnable.java: ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.mr.hive; + +import static org.assertj.core.api.Assertions.assertThat; + +import java.io.IOException; +import java.nio.file.Path; +import java.util.Collection; +import org.apache.hadoop.hive.common.StatsSetupConst; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.Parameter; +import org.apache.iceberg.ParameterizedTestExtension; +import org.apache.iceberg.Parameters; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.hadoop.ConfigProperties; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.TestTemplate; +import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.api.io.TempDir; + +@ExtendWith(ParameterizedTestExtension.class) +public class TestHiveIcebergWithHiveAutogatherEnable { + + @Parameters(name = "fileFormat={0}, catalog={1}") + public static Collection<Object[]> parameters() { + Collection<Object[]> testParams = Lists.newArrayList(); + // Run tests with every FileFormat for a single Catalog (HiveCatalog) + for (FileFormat fileFormat : HiveIcebergStorageHandlerTestUtils.FILE_FORMATS) { + testParams.add(new Object[] {fileFormat, TestTables.TestTableType.HIVE_CATALOG}); + } + return testParams; + } + + private static TestHiveShell shell; + + private TestTables testTables; + + @Parameter(index = 0) + private FileFormat fileFormat; + + @Parameter(index = 1) + private TestTables.TestTableType testTableType; + + @TempDir private Path temp; + + @BeforeAll + public static void beforeClass() { + // The hive configuration HIVESTATSAUTOGATHER must be set to true from hive engine + shell = + HiveIcebergStorageHandlerTestUtils.shell( + ImmutableMap.of(HiveConf.ConfVars.HIVESTATSAUTOGATHER.varname, "true")); + } + + @AfterAll + public static void afterClass() throws Exception { + shell.stop(); + } + + @BeforeEach + public void before() throws IOException { + testTables = HiveIcebergStorageHandlerTestUtils.testTables(shell, testTableType, temp); + HiveIcebergStorageHandlerTestUtils.init(shell, testTables, temp, "mz"); + } + + @AfterEach + public void after() throws Exception { + HiveIcebergStorageHandlerTestUtils.close(shell); + } + + @TestTemplate + public void testHiveStatsAutogatherWhenCreateNewTable() throws Exception { + // Create a Catalog where the KEEP_HIVE_STATS is false + shell.metastore().hiveConf().set(ConfigProperties.KEEP_HIVE_STATS, StatsSetupConst.FALSE); + TestTables hiveStatsDisabledTestTables = + HiveIcebergStorageHandlerTestUtils.testTables(shell, testTableType, temp); + + TableIdentifier identifierWithoutStats = + TableIdentifier.of("default", "customers_without_stats"); + + // To validate the stats augother is disabled from Hive engine, the creation of iceberg table + // cannot have any + // records. Otherwise, the table parameters TOTAL_SIZE and NUM_FILES are added by Iceberg when + // inserting records. Review Comment: nit: Could we format this a bit better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
