marvinlanhenke commented on code in PR #323:
URL: https://github.com/apache/iceberg-rust/pull/323#discussion_r1572233768
##########
crates/iceberg/src/scan.rs:
##########
@@ -186,6 +239,27 @@ impl TableScan {
.boxed())
}
+ fn create_manifest_eval_factory(
+ //&self,
+ id: &i32,
+ schema: SchemaRef,
+ table_metadata: Arc<TableMetadata>,
+ case_sensitive: bool,
+ filter: &Predicate,
+ ) -> ManifestEvaluator {
+ let bound_predicate = filter.bind(schema.clone(),
case_sensitive).unwrap();
Review Comment:
I'll guess this is the place where we want to apply `rewrite_not` - which
probably resolves our previous discussion in the PR for the
`InclusiveProjection`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
