nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1567077122
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -1796,6 +1799,48 @@ public void
testCatalogExpiredBearerTokenIsRefreshedWithCredential(String oauth2
any());
}
+
+ @Test
+ public void testCatalogWithPagaintionTokenIssue() {
+ //TODO remove this test, Used to highlight issue with namespaces
Review Comment:
alternatively you can also add the mockito verifications on `adapter` to the
other tests that you added (`testPaginationForListNamespaces()` /
`testPaginationForListTables()` / `testPaginationForListViews()`).
For `testPaginationForListNamespaces()` this test would do some additional
checks after creating all namespaces and listing them. Those verification
checks would be:
// verify config endpoint was called (which is e.g. what you already have in
L1822ff)
// verify create namespace was called X times
// verify list namespaces was called. Here is where you would verify that
the pagination token is properly exchanged via query params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
