aokolnychyi commented on code in PR #10123:
URL: https://github.com/apache/iceberg/pull/10123#discussion_r1566392268
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -43,6 +43,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (!addsDataFiles() && addsDeleteFiles()) {
Review Comment:
The use case you highlight is a valid one if FILE_A has all records removed
with deletes. Then removing FILE_A has no impact on the table state.
That being said, we should definitely heck if the validation is missing any
edge case. Thanks for looking into that!
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -43,6 +43,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (!addsDataFiles() && addsDeleteFiles()) {
Review Comment:
The use case you highlight is a valid one if FILE_A has all records removed
with deletes. Then removing FILE_A has no impact on the table state.
That being said, we should definitely check if the validation is missing any
edge case. Thanks for looking into that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
