aokolnychyi commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1566289821
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java:
##########
@@ -237,4 +237,11 @@ protected ExecutorService executorService(int
threadPoolSize, String nameFormat)
return executorService;
}
+
+ protected int checkAndGetArg(
Review Comment:
If we want to add this logic for validating the parser, we should do this
via `ProcedureInput`, not as a separate method. My suggestion would be to
revert this change and use the initial approach in this PR. In a separate PR,
we can switch MIGRATE and SNAPSHOT procedures to use `ProcedureInput` and add
the validation there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
