nastra commented on code in PR #10111:
URL: https://github.com/apache/iceberg/pull/10111#discussion_r1565731774
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -239,6 +240,9 @@ public void testSchemaIsMigratedToAddViewSupport() throws
Exception {
.create();
assertThat(jdbcCatalog.listViews(Namespace.of("namespace1"))).hasSize(1).containsExactly(view);
+
+ // testing append datafile to check commit, it should not throw an
exception
+ jdbcCatalog.loadTable(tableOne).newAppend().appendFile(FILE_A).commit();
Review Comment:
I think we should also make sure that we can create a new table after
migration and that the tables can be loaded. Something like this:
```
TableIdentifier tableThree = TableIdentifier.of("namespace2", "table3");
jdbcCatalog.createTable(tableThree, SCHEMA);
assertThat(jdbcCatalog.tableExists(tableThree)).isTrue();
// testing append datafile to check commit, it should not throw an
exception
jdbcCatalog.loadTable(tableOne).newAppend().appendFile(FILE_A).commit();
jdbcCatalog.loadTable(tableTwo).newAppend().appendFile(FILE_B).commit();
assertThat(jdbcCatalog.tableExists(tableOne)).isTrue();
assertThat(jdbcCatalog.tableExists(tableTwo)).isTrue();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
