Fokko commented on code in PR #597:
URL: https://github.com/apache/iceberg-python/pull/597#discussion_r1563143233
##########
pyiceberg/io/pyarrow.py:
##########
@@ -966,20 +965,15 @@ def _task_to_table(
with fs.open_input_file(path) as fin:
fragment = arrow_format.make_fragment(fin)
physical_schema = fragment.physical_schema
- schema_raw = None
- if metadata := physical_schema.metadata:
- schema_raw = metadata.get(ICEBERG_SCHEMA)
Review Comment:
My initial intent was that it was probably faster to deserialize the schema,
rather than run the visitor, but this shows is not worth the additional
complexity :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
