Fokko commented on code in PR #599:
URL: https://github.com/apache/iceberg-python/pull/599#discussion_r1563100274
##########
pyiceberg/table/__init__.py:
##########
@@ -3253,6 +3253,15 @@ def __init__(self, tbl: Table) -> None:
except ModuleNotFoundError as e:
raise ModuleNotFoundError("For metadata operations PyArrow needs
to be installed") from e
+ def _snapshot(self, snapshot_id: Optional[int] = None) ->
Optional[Snapshot]:
+ if snapshot_id:
Review Comment:
Nit. Otherwise, it will fail on Snapshot ID 0.
```suggestion
if snapshot_id is not None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
