chenwyi2 commented on issue #10129:
URL: https://github.com/apache/iceberg/issues/10129#issuecomment-2051540655
` private List<ManifestFile> findMatchingManifests() {
Snapshot currentSnapshot = table.currentSnapshot();
if (currentSnapshot == null) {
return ImmutableList.of();
}
String partitionFilter =
PropertyUtil.propertyAsString(options(), PARTITION_FILTER,
PARTITION_FILTER_DFAULT);
if (!partitionFilter.isEmpty()){
return currentSnapshot.dataManifests(table.io()).stream()
.filter(manifest -> manifest.partitionSpecId() ==
spec.specId() && predicate.test(manifest) &&
manifest.partitions() != null &&
partitionFilter.compareTo(Conversions.fromByteBuffer(
Types.StringType.get(),manifest.partitions().get(0).upperBound()))>=0)
.collect(Collectors.toList());
}
return currentSnapshot.dataManifests(table.io()).stream()
.filter(manifest -> manifest.partitionSpecId() == spec.specId() &&
predicate.test(manifest))
.collect(Collectors.toList());
}`
is that ok to only rewrite manifests whose upperBound is less than
PARTITION_FILTER?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
