nastra commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1561325160
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java:
##########
@@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends
RequestResponseTestBase<ListName
@Test
public void testRoundTripSerDe() throws JsonProcessingException {
- String fullJson = "{\"namespaces\":[[\"accounting\"],[\"tax\"]]}";
+ String fullJson =
"{\"namespaces\":[[\"accounting\"],[\"tax\"]],\"next-page-token\":null}";
Review Comment:
`toString()` shouldn't matter when the object is serialized to JSON. I guess
this is the downside of serializing to JSON via reflection (since we don't have
a separate parser for this class to better control what we
serialize/deserialize)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
