aokolnychyi commented on code in PR #10074:
URL: https://github.com/apache/iceberg/pull/10074#discussion_r1560322347
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkCatalogOperations.java:
##########
@@ -34,6 +38,41 @@
public class TestSparkCatalogOperations extends CatalogTestBase {
+ @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2}")
+ protected static Object[][] parameters() {
+ return new Object[][] {
+ {
+ SparkCatalogConfig.HIVE.catalogName(),
+ SparkCatalogConfig.HIVE.implementation(),
+ ImmutableMap.of(
+ "type", "hive",
+ "default-namespace", "default",
+ "use-nullable-query-schema", "false")
Review Comment:
Why always false? Don't we want to test both values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
