jbonofre commented on code in PR #10111:
URL: https://github.com/apache/iceberg/pull/10111#discussion_r1558816450
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -54,7 +54,29 @@ enum SchemaVersion {
static final String TABLE_RECORD_TYPE = "TABLE";
static final String VIEW_RECORD_TYPE = "VIEW";
- private static final String V1_DO_COMMIT_SQL =
+ private static final String V1_DO_COMMIT_TABLE_SQL =
+ "UPDATE "
+ + CATALOG_TABLE_VIEW_NAME
+ + " SET "
+ + JdbcTableOperations.METADATA_LOCATION_PROP
+ + " = ? , "
+ + JdbcTableOperations.PREVIOUS_METADATA_LOCATION_PROP
+ + " = ?"
+ + " WHERE "
+ + CATALOG_NAME
+ + " = ? AND "
+ + TABLE_NAMESPACE
+ + " = ? AND "
+ + TABLE_NAME
+ + " = ? AND "
+ + JdbcTableOperations.METADATA_LOCATION_PROP
+ + " = ? AND ("
+ + RECORD_TYPE
+ + " = ?"
Review Comment:
Yes I can hardcode. Just adding the or clause won't work as we need the
parenthesis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
