Fokko commented on code in PR #585:
URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1555048186
##########
pyiceberg/catalog/hive.py:
##########
@@ -199,6 +184,7 @@ def _annotate_namespace(database: HiveDatabase, properties:
Properties) -> HiveD
DateType: "date",
TimeType: "string",
TimestampType: "timestamp",
+ TimestamptzType: "timestamp",
Review Comment:
Thanks for the context, has been a while since working with the Hive catalog.
> How about we default to "timestamp with local time zone" and add a
HiveCatalog property (e.g. hive.hive2-compatible-mode) to use "timestamp" here
when it set to true?
I think that would be a great solution 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
